Writing unit tests for noir protocol circuits

[thankyou]

Hi,

As a side project, I’m auditing and writing unit tests for the Aztec Noir protocol circuits. I have a few questions for any of the devs"

1. Does your team accept PRs that introduce unit tests?
2. Is there any preferred best practices that I can align myself with when writing tests?

Thanks!

[joshc]

Hey @thankyou, thanks for reaching out and for your interest in contributing! Our protocol circuits are still changing, so I think it’s a bit preemptive to accept external PRs for protocol circuit unit tests.

I don’t think we have best practices for these tests documented yet, but you can see how we’ve written some here.

[thankyou]

Thanks @joshc.

Quick follow up question. Is there any stable Noir code that could use some tests? If not, that’s fine. I’ll just continue on in my little corner doing my audit :).

[joshc]

Looking through the open issues in the Noir repo, some of these look like good ones that you could pick up.

• Add a test to check that dependency management works properly #184
• Discuss if crates/nargo/src/cli/mod.rs tests are right placed #457
• Create more tests with exernal crates #734
• Add integration test for contract artifact output #1159
• Check if our inputs are malleable modulo the prime of the Field #2008
• Testing: Compile twice and hash bytecode to check for non-determinism #2036
• Run CLI vs WASM equivalence tests on a range of programs #2187
• Simplify the release acceptance tests #2262
• Release acceptance testing suite doesn’t report errors on windows. #2270
• Add fuzzy tests to noir #2888
• println call in nargo tests should start on a new line #2913
• Standardise location of test noir programs #3484
• Re-enable ignored tests #3802

[thankyou]

Thanks for the help @joshc!